huaxiangsun commented on a change in pull request #2584:
URL: https://github.com/apache/hbase/pull/2584#discussion_r514587250
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java
##########
@@ -433,9 +474,24 @@ private void locateInMeta(TableName tableName,
LocateRequest req) {
Scan scan = new Scan().withStartRow(metaStartKey).withStopRow(metaStopKey,
true)
.addFamily(HConstants.CATALOG_FAMILY).setReversed(true).setCaching(locatePrefetchLimit)
.setReadType(ReadType.PREAD);
- if (useMetaReplicas) {
- scan.setConsistency(Consistency.TIMELINE);
+
+ switch (this.metaReplicaMode) {
+ case LoadBalance:
+ int metaReplicaId = this.metaReplicaSelector.select(tableName,
req.row, req.locateType);
+ if (metaReplicaId != RegionInfo.DEFAULT_REPLICA_ID) {
+ // If the selector gives a non-primary meta replica region, then go
with it.
+ // Otherwise, just go to primary in non-hedgedRead mode.
+ scan.setConsistency(Consistency.TIMELINE);
+ scan.setReplicaId(metaReplicaId);
+ }
+ break;
+ case HedgedRead:
+ scan.setConsistency(Consistency.TIMELINE);
+ break;
+ default:
+ // do nothing
Review comment:
Now I thought about it, it makes sense. Maybe a
CatalogReplicaModeManager class which encaps mode and selector?
Let me create a followup jira after this is merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
