bharathv commented on pull request #6:
URL: https://github.com/apache/hbase-native-client/pull/6#issuecomment-719185147


   I figured out the issue, submitted a new PR with my patch on top #14. 
   
   A quick summary of my patch addition
   - Patched fizz/wangle to find boost libs and pass boost root during 
compilation
   - Fixed the linking issue (removed your WHOLE_ARCHIVE workaround), our 
linking is still a bit messed up but I think the patch should be ok for now
   - Added cyrussasl dependency so that its compiled correctly.
   
   Lets see how the precommit goes. There was an issue with libfmt-dev not 
available for ubuntu 16.04 but that looks optional, so removed it (not sure 
though).
   
   @phrocker Feel free to apply my patch on top of your PR, I don't wan't to 
take credit for your work with one small final patch :-).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to