Apache9 commented on pull request #2584: URL: https://github.com/apache/hbase/pull/2584#issuecomment-721481888
> You've addressed all my concerns, thank you. > > I'm sorry I didn't notice this earlier, but I think it's better if this is merged into the feature branch and we land the whole feature in one pass, rather than part on the branch and part directly into master. It makes sense now why a bunch of my comments seemed to disappear; they were on the earlier PR. > > I'm +1 for this change and prefer it land via the feature branch so that we can stabilize the client + server before merging to master and before back porting to branch-2. Landing this on master is proposed by me as this PR is not related to the server side changes. It can be used in our current code base, without the changes in HBASE-18070. And what's more, the client side code are different between master and branch-2, as on master, we rebuild the sync client on top of async client which makes it much easier to implement this issue but on branch-2, you need to deal with sync client separately. So I suggest we land this on master, and then start backporting to branch-2 ASAP. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
