carp84 commented on a change in pull request #2614:
URL: https://github.com/apache/hbase/pull/2614#discussion_r517158312
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSeparateClientZKCluster.java
##########
@@ -255,7 +260,20 @@ public void testAsyncTable() throws Exception {
Get get = new Get(row);
Result result = table.get(get).get();
LOG.debug("Result: " + Bytes.toString(result.getValue(family,
qualifier)));
- Assert.assertArrayEquals(value, result.getValue(family, qualifier));
+ assertArrayEquals(value, result.getValue(family, qualifier));
+ }
+ }
+
+ @Test
+ public void testChangeMetaReplicaCount() throws Exception {
Review comment:
Yes, and it seems the test now didn't test any `ClientZKSyncer` logics,
like if the client could still correctly access meta through client ZK, but
checks against meta region locator?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
