ddupg commented on a change in pull request #2452:
URL: https://github.com/apache/hbase/pull/2452#discussion_r517163741
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
##########
@@ -224,6 +226,35 @@ public void init(Configuration conf, FileSystem fs, Path
walDir,
this.abortOnError =
this.conf.getBoolean("replication.source.regionserver.abort",
true);
+ if (conf.getBoolean(HConstants.REPLICATION_OFFLOAD_ENABLE_KEY,
+ HConstants.REPLICATION_OFFLOAD_ENABLE_DEFAULT)) {
+ fetchWALsThread = new Thread(() -> {
Review comment:
interrrupt the `fetchWALsThread` when the ReplicationServer exits or
when the peer terminates?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]