virajjasani commented on a change in pull request #2623: URL: https://github.com/apache/hbase/pull/2623#discussion_r517324513
########## File path: hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestGsonUtil.java ########## @@ -0,0 +1,58 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.util; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; + +import org.apache.hadoop.hbase.HBaseClassTestRule; +import org.apache.hadoop.hbase.testclassification.MiscTests; +import org.apache.hadoop.hbase.testclassification.SmallTests; +import org.apache.hbase.thirdparty.com.google.gson.Gson; +import org.junit.ClassRule; +import org.junit.Test; +import org.junit.experimental.categories.Category; + +@Category({ MiscTests.class, SmallTests.class }) +public class TestGsonUtil { + + @ClassRule + public static final HBaseClassTestRule CLASS_RULE = + HBaseClassTestRule.forClass(TestGsonUtil.class); + + private static final Gson GSON = GsonUtil.createGson().create(); + private static final Gson DHE_GSON = GsonUtil.createGsonWithDisableHtmlEscaping().create(); + + @Test + public void testDisableHtmlEscaping() { + String testStr = "==="; + + // disable html escaping + String json = DHE_GSON.toJson(testStr); + assertTrue(json.startsWith("\"") && json.endsWith("\"")); + assertEquals(testStr.length() + 2, json.length()); + assertEquals(testStr, json.substring(1, json.length() - 1)); Review comment: One more assert or maybe replace with this one: ``` assertEquals("\"===\"", json); ``` ########## File path: hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestGsonUtil.java ########## @@ -0,0 +1,58 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.util; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; + +import org.apache.hadoop.hbase.HBaseClassTestRule; +import org.apache.hadoop.hbase.testclassification.MiscTests; +import org.apache.hadoop.hbase.testclassification.SmallTests; +import org.apache.hbase.thirdparty.com.google.gson.Gson; +import org.junit.ClassRule; +import org.junit.Test; +import org.junit.experimental.categories.Category; + +@Category({ MiscTests.class, SmallTests.class }) +public class TestGsonUtil { + + @ClassRule + public static final HBaseClassTestRule CLASS_RULE = + HBaseClassTestRule.forClass(TestGsonUtil.class); + + private static final Gson GSON = GsonUtil.createGson().create(); + private static final Gson DHE_GSON = GsonUtil.createGsonWithDisableHtmlEscaping().create(); + + @Test + public void testDisableHtmlEscaping() { + String testStr = "==="; + + // disable html escaping + String json = DHE_GSON.toJson(testStr); + assertTrue(json.startsWith("\"") && json.endsWith("\"")); + assertEquals(testStr.length() + 2, json.length()); + assertEquals(testStr, json.substring(1, json.length() - 1)); + + // enable html escaping, turn '=' into '\u003d' + json = GSON.toJson(testStr); + assertTrue(json.startsWith("\"") && json.endsWith("\"")); + assertEquals(testStr.length() * 6 + 2, json.length()); + assertEquals(testStr.replaceAll("=", "\\\\u003d"), + json.substring(1, json.length() - 1)); Review comment: One more assert or maybe replace with this one: ``` assertEquals("\"\\u003d\\u003d\\u003d\"", json); ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
