apurtell commented on a change in pull request #2627:
URL: https://github.com/apache/hbase/pull/2627#discussion_r518898534
##########
File path:
hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestBytes.java
##########
@@ -58,7 +59,7 @@ private static void setUnsafe(boolean value) throws Exception
{
} finally {
modifiersField.setInt(field, oldModifiers);
}
- assertEquals(Bytes.UNSAFE_UNALIGNED, value);
+ assertEquals(UnsafeAvailChecker.unaligned(), value);
}
Review comment:
While we are here, and this is not a requirement (I've already approved
the PR), would be good to have a small new unit test that confirms the new
configuration parameter does in fact disable Unsafe usage when we would
otherwise use it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
