esteban commented on a change in pull request #2539:
URL: https://github.com/apache/hbase/pull/2539#discussion_r520025893
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/Encryption.java
##########
@@ -215,7 +215,7 @@ public static boolean
failOnHashAlgorithmMismatch(Configuration conf) {
* Return the MD5 digest of the concatenation of the supplied arguments.
*/
public static byte[] hash128(String... args) {
- return hashWithAlg("MD5", args);
+ return hashWithAlg("MD5", Bytes.toByteArrays(args));
Review comment:
It's fine. hashWithAlg is private anyways so there shouldn't be any need
to pass a String argument ever.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
