huaxiangsun commented on a change in pull request #2640:
URL: https://github.com/apache/hbase/pull/2640#discussion_r520937824



##########
File path: 
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ReversedClientScanner.java
##########
@@ -64,7 +64,9 @@ protected boolean setNewStartKey() {
 
   @Override
   protected ReversedScannerCallable createScannerCallable() {
+    // In case of meta, we want to support scan over a replica region.
+    int replicaId = (scan.getConsistency() == Consistency.TIMELINE) ? 
scan.getReplicaId() : 0;

Review comment:
       For testing failures, it is my misunderstanding of the default 
targetReplicaId is 0 (actually it is -1). Introduce a utility method to 
differentiate the case for scan over a specific replica region in TIMELINE mode.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to