huaxiangsun commented on a change in pull request #2645:
URL: https://github.com/apache/hbase/pull/2645#discussion_r521488955
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallableWithReplicas.java
##########
@@ -209,13 +209,13 @@ public MoreResults moreResultsForScan() {
LOG.debug("Scan with primary region returns " + e.getCause());
}
- // If rl's size is 1 or scan's consitency is strong, it needs to throw
- // out the exception from the primary replica
- if ((regionReplication == 1) || (scan.getConsistency() ==
Consistency.STRONG)) {
+ // If rl's size is 1 or scan's consistency is strong or a specific
replica id has been
+ // specified, it needs to throw out the exception from the first tried
replica
+ if (regionReplication == 1 || scan.getConsistency() ==
Consistency.STRONG ||
+ scan.getReplicaId() >= 0) {
Review comment:
More changes are needed in ScannerCallableWithReplicas. It is hard to
copy the diff in the right format, so I post the patch in the jira. Put the
link here.
[https://issues.apache.org/jira/browse/HBASE-25272]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
