virajjasani commented on a change in pull request #2679:
URL: https://github.com/apache/hbase/pull/2679#discussion_r526774608
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/SimpleLoadBalancer.java
##########
@@ -136,7 +136,7 @@ public void onConfigurationChange(Configuration conf) {
super.setConf(conf);
LOG.info("Update configuration of SimpleLoadBalancer, previous slop is "
+ originSlop + ", current slop is " + slop + "previous overallSlop
is" +
- originOverallSlop + ", current overallSlop is " +
originOverallSlop);
+ originOverallSlop + ", current overallSlop is " + overallSlop);
Review comment:
nit: can you use parameterized `{}` log syntax?
```
LOG.info(
"Update configuration of SimpleLoadBalancer, previous slop is {},
current slop is {} previous overallSlop is {}, current overallSlop is {}",
originSlop, slop, originOverallSlop, overallSlop);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
