Apache9 commented on pull request #2681: URL: https://github.com/apache/hbase/pull/2681#issuecomment-731152351
> for context, see the [overview of android flavors ](https://github.com/google/guava#guava-google-core-libraries-for-java)which calls out the android flavor for those who need jdk7: > > > Guava comes in two flavors. > > > > * The JRE flavor requires JDK 1.8 or higher. > > * If you need support for JDK 1.7 or Android, use the Android flavor. You can find the Android Guava source in the android directory. > > We use [release 30](https://github.com/google/guava/releases/tag/v30.0), that still has both. Looks like there are some differences; at a glance looks related to jdk8 specific stuff: [jdiff report for 30-android vs 30-jre](https://guava.dev/releases/30.0-android/api/androiddiffs/). Looking at the diffs, I suggest that we make a new release line of hbase-thirdparty for 1.x. We have deeply involved with JDK8 features on 2.x, and Guava has been widely used across the whole code base so it will be a pain if we can not use JDK8 specific feature on 2.x. It is not the same with the gson library. What do you think @apurtell ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
