apurtell commented on a change in pull request #2681:
URL: https://github.com/apache/hbase/pull/2681#discussion_r527911332
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java
##########
@@ -436,7 +434,6 @@ public void setOperationTimeout(int operationTimeout) {
* @return pool if non null, otherwise returns this.pool if non null,
otherwise throws
* RuntimeException
*/
- @VisibleForTesting
Review comment:
There is some kind of compiler problem with this particular annotation
and this particular unit. The annotation is available on the classpath and
other kinds of references (classes, methods) from the same shaded package are
fine.
I would argue that overall our usage of VisibleForTesting brings a binding
to Guava for no good reason. We could make our own annotation that communicates
the same things. However, I do not propose removal or replacement of
VisibleForTesting in this PR (even though it would be a good long term thing),
only specifically where it is causing odd compiler problems. The compiler used
is OpenJDK 11+7 GA. There are two files affected in two modules.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
