apurtell commented on a change in pull request #2681:
URL: https://github.com/apache/hbase/pull/2681#discussion_r527925161
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileManager.java
##########
@@ -72,7 +70,7 @@ void addCompactionResults(
* Clears all the files currently in use and returns them.
* @return The files previously in use.
*/
- ImmutableCollection<StoreFile> clearFiles();
Review comment:
StoreFileManager is a private class so this interface change is fine.
Just want to call out that I made the change here for the same reason as
other places. We should not be receiving or returning Guava types in our
interfaces. This introduces potential compatibility problems. Guava itself
evolves and fairly frequently makes breaking changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
