apurtell commented on a change in pull request #2681:
URL: https://github.com/apache/hbase/pull/2681#discussion_r527932125
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/SimpleRegionObserver.java
##########
@@ -248,7 +246,7 @@ public void
preCompactSelection(ObserverContext<RegionCoprocessorEnvironment> c,
@Override
public void
postCompactSelection(ObserverContext<RegionCoprocessorEnvironment> c,
- Store store, ImmutableList<StoreFile> selected) {
Review comment:
Downstream consequence of a RegionObserver API fix. This method should
not receive Guava's ImmutableList as type, it should simply be List. Using
ImmutableList to represent the fact that this list is, and should be,
immutable, is nice, but binds a LimitedPrivate interface to the vagaries of
Guava's frequent breaking changes as it itself evolves.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
