meszibalu commented on a change in pull request #2685:
URL: https://github.com/apache/hbase/pull/2685#discussion_r528302890
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/util/PoolMap.java
##########
@@ -45,177 +36,138 @@
* key. A size of {@link Integer#MAX_VALUE} is interpreted as an unbounded
pool.
* </p>
*
+ * <p>
+ * PoolMap is thread-safe. It does not remove elements automatically. Unused
resources
+ * must be closed and removed explicitly.
+ * </p>
Review comment:
No or at least not trivial. Synchronization is used for stopping also
and we would need some extra methods in `PoolMap` like `close()`, `drainTo()`,
etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
