zhengzhuobinzzb commented on a change in pull request #2664:
URL: https://github.com/apache/hbase/pull/2664#discussion_r528442604
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
##########
@@ -1389,29 +1396,25 @@ public byte getFamilyLength(int foffset) {
*/
@Override
public int getQualifierOffset() {
- return getQualifierOffset(getFamilyOffset());
+ return getQualifierInternalPosition(getFamilyOffset(), getFamilyLength());
}
- /**
- * @return Qualifier offset
- */
- private int getQualifierOffset(int foffset) {
- return foffset + getFamilyLength(foffset);
+ @Override
+ public int getQualifierInternalPosition(int famOffset, byte famLength) {
+ return famOffset + famLength;
Review comment:
Is this not current?
famOffset + famLength + Bytes.SIZEOF_BYTE = qualifierInternalPosition
famOffset + famLength = quelifierLengthPosition
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
