virajjasani commented on a change in pull request #2689:
URL: https://github.com/apache/hbase/pull/2689#discussion_r528858946



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java
##########
@@ -60,10 +62,29 @@ public void preClean() {
       wals = queueStorage.getAllWALs();
     } catch (ReplicationException e) {
       LOG.warn("Failed to read zookeeper, skipping checking deletable files");

Review comment:
       @cuibo01 I think you missed putting warning in `else` block. Please 
check the sample provided above.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to