[ 
https://issues.apache.org/jira/browse/HBASE-24640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17237667#comment-17237667
 ] 

Andrew Kyle Purtell commented on HBASE-24640:
---------------------------------------------

Here is what I plan to do:
 * Find all VisibleForTesting annotations.
 * If the enclosing class or interface is IA Public or LImitedPrivate, replace 
the VisibleForTesting annotation with IA.Private.
 * If the enclosing class or interface is IA Private, remove the 
VisibleForTesting annotation.

> Purge use of VisibleForTesting
> ------------------------------
>
>                 Key: HBASE-24640
>                 URL: https://issues.apache.org/jira/browse/HBASE-24640
>             Project: HBase
>          Issue Type: Task
>          Components: community
>    Affects Versions: 3.0.0-alpha-1, 2.4.0
>            Reporter: Nick Dimiduk
>            Assignee: Andrew Kyle Purtell
>            Priority: Major
>
> From the dev-list thread ["[DISCUSS] VisibleForTesting annotation as it 
> pertains to our API compatibility 
> guidelines"|https://lists.apache.org/thread.html/rc7c7c66f134fe135d0a4454a883215e26ff3d20e5a31ecd6a2d1db77%40%3Cdev.hbase.apache.org%3E],
>  when used in classes annotated with interface audience other than 
> IA.Private, the VisibleForTesting annotation is confusing and considered 
> harmful. The consensus is that we do not want to use this annotation as part 
> of the definition of our public APIs, and we need to remove the point of 
> confusion.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to