[
https://issues.apache.org/jira/browse/HBASE-25324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yuqi updated HBASE-25324:
-------------------------
Description:
{code:java}
public static List<FileStatus> getFileList(final Configuration conf, final
List<Path> logDirs,
final PathFilter filter)
throws IOException {
List<FileStatus> fileStatus = new ArrayList<>();
....
FileStatus[] a = new FileStatus[fileStatus.size()];
return fileStatus.toArray(a);
}
public List<FileStatus> getWALsToSplit(ServerName serverName, boolean
splitMeta)
throws IOException {
List<Path> logDirs =
master.getMasterWalManager().getLogDirs(Collections.singleton(serverName));
FileStatus[] fileStatuses =
SplitLogManager.getFileList(this.conf, logDirs, splitMeta ? META_FILTER
: NON_META_FILTER);
LOG.info("{} WAL count={}, meta={}", serverName, fileStatuses.length,
splitMeta);
//list convert to array and array convert to list again
return Lists.newArrayList(fileStatuses);
{code}
> Remove unnecessary array to list conversion SplitLogManager
> -----------------------------------------------------------
>
> Key: HBASE-25324
> URL: https://issues.apache.org/jira/browse/HBASE-25324
> Project: HBase
> Issue Type: Improvement
> Environment: {code:java}
> public static List<FileStatus> getFileList(final Configuration conf, final
> List<Path> logDirs,
> final PathFilter filter)
> throws IOException {
> List<FileStatus> fileStatus = new ArrayList<>();
> ....
> FileStatus[] a = new FileStatus[fileStatus.size()];
> return fileStatus.toArray(a);
> }
> public List<FileStatus> getWALsToSplit(ServerName serverName, boolean
> splitMeta)
> throws IOException {
> List<Path> logDirs =
> master.getMasterWalManager().getLogDirs(Collections.singleton(serverName));
> FileStatus[] fileStatuses =
> SplitLogManager.getFileList(this.conf, logDirs, splitMeta ?
> META_FILTER : NON_META_FILTER);
> LOG.info("{} WAL count={}, meta={}", serverName, fileStatuses.length,
> splitMeta);
> //list convert to array and array convert to list again
> return Lists.newArrayList(fileStatuses);
>
> {code}
> Reporter: yuqi
> Assignee: yuqi
> Priority: Minor
>
> {code:java}
> public static List<FileStatus> getFileList(final Configuration conf, final
> List<Path> logDirs,
> final PathFilter filter)
> throws IOException {
> List<FileStatus> fileStatus = new ArrayList<>();
> ....
> FileStatus[] a = new FileStatus[fileStatus.size()];
> return fileStatus.toArray(a);
> }
> public List<FileStatus> getWALsToSplit(ServerName serverName, boolean
> splitMeta)
> throws IOException {
> List<Path> logDirs =
> master.getMasterWalManager().getLogDirs(Collections.singleton(serverName));
> FileStatus[] fileStatuses =
> SplitLogManager.getFileList(this.conf, logDirs, splitMeta ?
> META_FILTER : NON_META_FILTER);
> LOG.info("{} WAL count={}, meta={}", serverName, fileStatuses.length,
> splitMeta);
> //list convert to array and array convert to list again
> return Lists.newArrayList(fileStatuses);
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
