anoopsjohn commented on a change in pull request #2675:
URL: https://github.com/apache/hbase/pull/2675#discussion_r530116513
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
##########
@@ -299,6 +304,11 @@ public RegionCoprocessorHost(final HRegion region,
} catch (NoSuchMethodException ignore) {
}
clazz = clazz.getSuperclass();
+
Review comment:
Actually change can be at begin of this loop
if (clazz == null) {
// we must have directly implemented RegionObserver
hasCustomPostScannerFilterRow = true;
break out;
}
In 1.x we have interface with no def impl. So we have to consider like
hasCustomPostScannerFilterRow = true then. But in 2.x we have Interface with
default impl. So its safe to change there to be hasCustomPostScannerFilterRow
= false only.
In fact that check can be as urs
if (clazz == Object.class) {
break out;
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
