sunhelly commented on pull request #2699: URL: https://github.com/apache/hbase/pull/2699#issuecomment-733530907
> Looks like it just adding a try/finally so we always unbuffer. Thats good. We weren't calling unbuffer ever? Thanks. Otherwise patch looks good to me. Thanks for reviewing, @saintstack . `unbuffer` currently is called in `HFile.createReader`, but when reading blocks by stream reader, new block reader might be created, and `unbuffer` is needed after that. I think `initTrailerAndContext` and `initMetaAndIndex` need to call `unbuffer`, too. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
