petersomogyi commented on a change in pull request #2676:
URL: https://github.com/apache/hbase/pull/2676#discussion_r530355058
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEncryptionDisabled.java
##########
@@ -47,6 +46,9 @@
public static final HBaseClassTestRule CLASS_RULE =
HBaseClassTestRule.forClass(TestEncryptionDisabled.class);
+ @Rule
+ public ExpectedException exception = ExpectedException.none();
Review comment:
👍
##########
File path: src/main/asciidoc/_chapters/security.adoc
##########
@@ -1713,12 +1749,20 @@ Refer to the official API for usage instructions.
Enable Encryption on a Column Family::
To enable encryption on a column family, you can either use HBase Shell or
the Java API.
After enabling encryption, trigger a major compaction.
- When the major compaction completes, the HFiles will be encrypted.
+ When the major compaction completes, the compacted new HFiles will be
encrypted.
+ However, depending on the compaction settings, it is possible that not all
the HFiles will be
+ rewritten during a major compaction and there still might remain some old
unencrypted HFiles.
+ Also please note, that the snapshots are immutable. So the snapshots taken
before you enabled the
+ encryption will still contain the unencrypted HFiles.
Review comment:
I like that you pointed out this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
