virajjasani commented on a change in pull request #2705:
URL: https://github.com/apache/hbase/pull/2705#discussion_r531079247
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMasterCommandLine.java
##########
@@ -139,7 +148,15 @@ public int run(String args[]) throws Exception {
if ("start".equals(command)) {
return startMaster();
} else if ("stop".equals(command)) {
- return stopMaster();
+ if (shutDownCluster) {
+ return stopMaster();
+ }
+ System.err.println(
+ "To shutdown the master run " +
+ "hbase-daemon.sh stop master or send a kill signal to " +
+ "the HMaster pid, " +
+ "and to stop HBase Cluster run stop-hbase.sh or add --shutDownCluster
with current command");
Review comment:
nit:
```
and to stop HBase Cluster run: "stop-hbase.sh" or "hbase master stop
--shutDownCluster"
```
##########
File path: bin/stop-hbase.sh
##########
@@ -22,12 +22,24 @@
# Stop hadoop hbase daemons. Run this on master node.
+usage="Usage: stop-hbase.sh can only be used for shutting down entire cluster\
+ to shut down (HMaster|HRegionServer) use hbase-daemon.sh stop
(master|regionserver)"
Review comment:
Great!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
