anoopsjohn commented on a change in pull request #2675:
URL: https://github.com/apache/hbase/pull/2675#discussion_r531575006
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
##########
@@ -275,11 +280,11 @@ public RegionCoprocessorHost(final HRegion region,
out: for (RegionCoprocessorEnvironment env: coprocEnvironments) {
if (env.getInstance() instanceof RegionObserver) {
Class<?> clazz = env.getInstance().getClass();
- for(;;) {
- if (clazz == null) {
- // we must have directly implemented RegionObserver
- hasCustomPostScannerFilterRow = true;
- break out;
+ while (clazz != null) {
+ if (clazz == Object.class) {
+ // we dont need to look postScannerFilterRow into Object class
+ clazz = null;
+ continue;
Review comment:
U can basically break at this point? Come out of the inner loop.
Could have kept for(;;) { as is also.
Just to keep the change to be 3 lines only
Minor suggestion though
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
