[
https://issues.apache.org/jira/browse/HBASE-25237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239776#comment-17239776
]
Hudson commented on HBASE-25237:
--------------------------------
Results for branch branch-2.2
[build #127 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/127/]:
(x) *{color:red}-1 overall{color}*
----
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/127//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/127//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/127//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/127//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> 'hbase master stop' shuts down the cluster, not the master only
> ---------------------------------------------------------------
>
> Key: HBASE-25237
> URL: https://issues.apache.org/jira/browse/HBASE-25237
> Project: HBase
> Issue Type: Improvement
> Reporter: Michael Stack
> Assignee: Lokesh Khurana
> Priority: Major
> Fix For: 3.0.0-alpha-1, 1.7.0, 2.4.0, 2.2.7, 2.3.4
>
> Attachments: HBASE-25237.patch
>
>
> This is confusing (an operator at place-of-employment shut down a massive
> cluster mistakenly thinking he was shutting down the master only).
> If I run 'hbase master --help', it says unsupported and then dumps out:
> {code:java}
> org.apache.hbase.thirdparty.org.apache.commons.cli.UnrecognizedOptionException:
> Unrecognized option: --help
> at
> org.apache.hbase.thirdparty.org.apache.commons.cli.Parser.processOption(Parser.java:383)
> at
> org.apache.hbase.thirdparty.org.apache.commons.cli.Parser.parse(Parser.java:210)
> at
> org.apache.hbase.thirdparty.org.apache.commons.cli.Parser.parse(Parser.java:88)
> at
> org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterCommandLine.java:89)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
> at
> org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerCommandLine.java:149)
> at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:2945)
> Usage: Master [opts] start|stop|clear
> start Start Master. If local mode, start Master and RegionServer in same JVM
> stop Start cluster shutdown; Master signals RegionServer shutdown
> clear Delete the master znode in ZooKeeper after a master crashes
> where [opts] are:
> --minRegionServers=<servers> Minimum RegionServers needed to host user
> tables.
> --localRegionServers=<servers> RegionServers to start in master process when
> in standalone mode.
> --masters=<servers> Masters to start in this process.
> --backup Master should start in backup mode{code}
>
> ... so the 'help' is clear that its the cluster that goes down, not just the
> master – but that is hardly compensates for the unexpected behavior.
>
> 'hbase master stop' is actually what is used internally you run stop-hbase.sh.
>
> Stopping the cluster when your run 'hbase master stop' is actually very old
> behavior. Its still confusing though. We could change this.
> If I run 'hbase regionserver stop', it does this:
> {code:java}
> System.err.println(
> "To shutdown the regionserver run " +
> "hbase-daemon.sh stop regionserver or send a kill signal to " +
> "the regionserver pid");{code}
> I'd think we could make improvement here. We could do something like the RS
> output if user types 'hbase master stop' at a minimum requiring operator add
> a '–force' flag if they want the cluster to go down or point them to a new
> hbase cluster stop/hbase cluster start or point them at stop-hbase.sh.
> Should also change mode so 'hbase master stop' stops the master and not the
> cluster (there was no stopMaster when the 'hbase master stop' was added
> originally – but there is one now).
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
