[
https://issues.apache.org/jira/browse/HBASE-25308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17242570#comment-17242570
]
Andrew Kyle Purtell edited comment on HBASE-25308 at 12/2/20, 5:51 PM:
-----------------------------------------------------------------------
Oh, this patch cannot work until there is an hbase-thirdparty that works with
JDK7. As you can see I linked HBASE-25316 as blocker.
Once there is a hbase-thirdparty release that only includes classfiles
compatible with JDK7 the compile report will look much better. I have been
testing this patch with Java 11 with sourcelevel = 7. The sources are 7
compatible but the bytecode imported from hbase-thirdparty at the moment is
not, which is why precommit is having problems.
was (Author: apurtell):
Oh, this patch cannot work until there is an hbase-thirdparty that works with
JDK7. As you can see I linked HBASE-25316 as blocker.
Once there is a hbase-thirdparty release that only includes classfiles
compatible with JDK7 the compile report will look much better.
> [branch-1] Consume Guava from hbase-thirdparty hbase-shaded-miscellaneous
> -------------------------------------------------------------------------
>
> Key: HBASE-25308
> URL: https://issues.apache.org/jira/browse/HBASE-25308
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Kyle Purtell
> Assignee: Andrew Kyle Purtell
> Priority: Major
> Fix For: 1.7.0
>
>
> We are again having classpath versioning issues related to Guava in our
> branch-1 based application.
> Hadoop 3, HBase 2, Phoenix 5, and other projects deal with Guava
> cross-version incompatibilities, as they manifest on a combined classpath
> with other components, via shading.
> I propose to do a global search and replace of all direct uses of Guava in
> our branch-1 code base and refer to Guava as provided in hbase-thirdparty's
> hbase-shaded-miscellaneous. This will protect HBase branch-1 from Guava
> cross-version vagaries just like the same technique protects branch-2 and
> branch-2 based releases.
> There are a couple of Public or LimitedPrivate interfaces that incorporate
> Guava's HostAndPort and Service that will be indirectly impacted. We are
> about to release a new minor branch-1 version, 1.7.0, and this would be a
> great opportunity to introduce this kind of change in a manner consistent
> with semantic versioning and our compatibility policies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
