sunhelly commented on a change in pull request #2657:
URL: https://github.com/apache/hbase/pull/2657#discussion_r535860582
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/DeadServer.java
##########
@@ -96,29 +75,6 @@ synchronized boolean areDeadServersInProgress() {
*/
synchronized void putIfAbsent(ServerName sn) {
this.deadServers.putIfAbsent(sn, EnvironmentEdgeManager.currentTime());
- processing(sn);
- }
Review comment:
These codes are not only set the server be dead, but also set it be
processing.
But the changed codes only set it be dead.
As a result ,when calling `ServerManager.expireServer()` method, the server
is firstly set be dead by `moveFromOnlineToDeadServers()`, but the SCP is
submitted afterwards.
So this patch made a diff from the origin codes when calling
`ServerManager.areDeadServersInProgress()`, because the new codes has a little
delay time of submit and execute the SCP procedure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
