sunhelly commented on pull request #2728: URL: https://github.com/apache/hbase/pull/2728#issuecomment-738593059
> Tried locally, TestRSGroupsFallback still failed. Could you two please confirm it again? And mind explaining a bit why HBASE-25282 could make this test fail? What's the root cause? > @Apache9 @yuqi1129 I looked through the patch of HBASE-25282 and found a little clue. I have commented [PR of HBASE-25282](https://github.com/apache/hbase/pull/2657/files#) . Does it fails at `assertRegionsInGroup` after `crashRsInGroup(groupName)` ? @Apache9 (I can't reproduce the failure of this UT, while few days ago it failed after `MASTER.balance()` as I have attached the links in the description of HBASE-25334). I think to fix this failure, two places need to be corrected. One is modify `ServerManager.expireServer`, move the calling of `moveFromOnlineToDeadServers(serverName);` after submit SCP. The other is change `AssignmentTestingUtil.waitForRsToBeDead()`, it should check both server is in the dead list and no SCP procedures exists. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
