Apache9 commented on a change in pull request #1202:
URL: https://github.com/apache/hbase/pull/1202#discussion_r535911532
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/trace/TraceUtil.java
##########
@@ -34,17 +51,24 @@
private static HTraceConfiguration conf;
private static Tracer tracer;
+ private static io.opentracing.Tracer otTracer;
+
+ private static final Logger LOG =
LoggerFactory.getLogger(TraceUtil.class.getName());
+
+
private TraceUtil() {
}
- public static void initTracer(Configuration c) {
- if (c != null) {
- conf = new HBaseHTraceConfiguration(c);
- }
+ public static void initTracer(Configuration c, String serviceName) {
+ if (!GlobalTracer.isRegistered()) {
+ io.jaegertracing.Configuration conf =
io.jaegertracing.Configuration.fromEnv(serviceName);
Review comment:
Can we avoid referencing jaeger directly in code? I would expect that
this just work like slf4j, when only need to depend on log4j when testing or at
runtime, not compile time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
