saintstack commented on a change in pull request #2733:
URL: https://github.com/apache/hbase/pull/2733#discussion_r536826539
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -627,7 +628,16 @@ public Configuration getConfiguration() {
private void checkClosed() throws DoNotRetryIOException {
if (this.closed) {
- throw new DoNotRetryIOException(toString() + " closed");
+ throw new ConnectionClosedException(toString() + " closed");
+ }
+ }
+
+ /**
+ * Thrown when connection is closed.
+ */
+ private static class ConnectionClosedException extends DoNotRetryIOException
{
+ ConnectionClosedException(String message) {
+ super(message);
Review comment:
Good question. I didn't even see this class import.
Looking at it, the CCE is no good to me and I think probably no good to
anyone since it doesn't subclass DoNotRetryIOE. I left a TODO on that class and
called this private local class LocalCCE instead. Thanks @huaxiangsun . Let me
update the patch. Will merge if all good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
