ramkrish86 commented on a change in pull request #2663:
URL: https://github.com/apache/hbase/pull/2663#discussion_r539128082
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
##########
@@ -786,6 +791,21 @@ private void updateMetricsStore(boolean memstoreRead) {
}
}
+ private void doSeekCol(Cell cell) throws IOException {
+ // we check when ever a seek_next_col happens did the seek really land in
a new block.
+ // If the seek always lands in the same current block while trying to do a
next(),
+ // we tend to go with next() rather than seek() based on the
'seekToSameBlock'
+ // which is updated in the method 'seekOrSkipToNextColumn'. Do this when
rowColBloom
+ // is not used
+ if (this.matcher.isUserScan() && !get && !useRowColBloom && seekToSameBlock
+ && bytesRead > switchToNextOnlyBytes) {
Review comment:
Oh I got your point. The reason to do that was to see if we can
introduce a new config for that instead of using preadMaxBytes config. I have
not added a config (ie. a TODO). That config can be for now directly referring
to preadMaxBytes or may be make it a new value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
