virajjasani commented on a change in pull request #2756:
URL: https://github.com/apache/hbase/pull/2756#discussion_r539393476
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java
##########
@@ -612,6 +612,8 @@ private String getHBase1CompatibleName(final String
comparator) {
comparatorKlass = CellComparatorImpl.class;
} else if
(comparatorClassName.equals(KeyValue.META_COMPARATOR.getLegacyKeyComparatorName())
||
comparatorClassName.equals(KeyValue.META_COMPARATOR.getClass().getName())
+ ||
(comparatorClassName.equals("org.apache.hadoop.hbase.CellComparator$MetaCellComparator"))
+ ||
(comparatorClassName.equals("org.apache.hadoop.hbase.CellComparatorImpl$MetaCellComparator"))
Review comment:
Is `CellComparator` not enough? I just checked previous commit where
only `CellComparator` was present and not `CellComparatorImpl`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
