[
https://issues.apache.org/jira/browse/HBASE-25378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246648#comment-17246648
]
Anoop Sam John commented on HBASE-25378:
----------------------------------------
At first thought its a data compatibility break issue.
Seems this wont create a compatibility issue by not able to read old cluster
generated HFiles. Because when we write the comparator class name in FFT, we
still use 1.x based comparator names
See FFT#toProtobuf ()
{code}
.setComparatorClassName(getHBase1CompatibleName(comparatorClassName))
..
private String getHBase1CompatibleName(final String comparator) {
if (comparator.equals(CellComparatorImpl.class.getName())) {
return KeyValue.COMPARATOR.getClass().getName();
}
if (comparator.equals(MetaCellComparator.class.getName())) {
return KeyValue.META_COMPARATOR.getClass().getName();
}
return comparator;
}
{code}
Though u can confirm with functional tests once.
> Legacy comparator in Hfile trailer will fail to load
> ----------------------------------------------------
>
> Key: HBASE-25378
> URL: https://issues.apache.org/jira/browse/HBASE-25378
> Project: HBase
> Issue Type: Bug
> Affects Versions: 3.0.0-alpha-1, 2.4.0, 2.3.2
> Reporter: Pankaj Kumar
> Assignee: Pankaj Kumar
> Priority: Critical
> Fix For: 3.0.0-alpha-1, 2.4.0, 2.3.4
>
>
> HBASE-24968 moved MetaCellComparator out from CellComparatorImpl to avoid the
> deadlock issue. But this introduced compatibility issue, old hfile with
> comparator class as
> "org.apache.hadoop.hbase.CellComparator$MetaCellComparator" will fail to open
> due to ClassNotFoundException.
> Also we should also handle the case when comparator class is
> "org.apache.hadoop.hbase.CellComparatorImpl$MetaCellComparator", which was
> case before HBASE-24968.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
