[ 
https://issues.apache.org/jira/browse/HBASE-25328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246728#comment-17246728
 ] 

Hudson commented on HBASE-25328:
--------------------------------

Results for branch branch-2
        [build #125 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/125/]:
 (/) *{color:green}+1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/125/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/125/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/125/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/125/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Add builder method to create Tags.
> ----------------------------------
>
>                 Key: HBASE-25328
>                 URL: https://issues.apache.org/jira/browse/HBASE-25328
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Rushabh Shah
>            Assignee: Rushabh Shah
>            Priority: Minor
>             Fix For: 3.0.0-alpha-1, 2.2.7, 2.3.4, 2.5.0, 2.4.1
>
>
> In PHOENIX-6213 phoenix project is using Cell Tag feature to add some 
> metadata for delete mutations. We are adding Cell Tags in co-processor but we 
> need some util methods available in +PrivateCellUtil+ class. 
> Below are the methods we need in phoenix.
> 1. +PrivateCellUtil#createCell(Cell cell, List<Tag> tags)+ method has an api 
> which will accept an existing Cell and list of tags to create a new cell. 
> But RawCellBuilder has a builder method which doesn't have any method which 
> accepts a cell. I need to explicitly convert my input cell by extracting all 
> fields and use the builder methods (like setRow, setseFamily, etc) and then 
> use the build method.
>  
> 2. +PrivateCellUtil.getTags(Cell cell)+ returns a list of existing tags which 
> I want to use and add a new tag.
> But RawCell#getTags() returns Iterator<Tag>  which then I have to iterate 
> over them and depending on whether they are byte buffer backed or array 
> backed, I need to convert them to List since RawCellBuilder#setTags accepts 
> List of Tags. We are already doing this conversion in PrivateCellUtil#getTags 
> method.
> All these conversion utility methods needs to be duplicated in phoenix 
> project also.
>  
> Is it reasonable to make PrivateCellUtil method LimitedPrivate with 
> HBaseInterfaceAudience as COPROC ?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to