ramkrish86 commented on a change in pull request #2747:
URL: https://github.com/apache/hbase/pull/2747#discussion_r541902477
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/ByteBufferKeyOnlyKeyValue.java
##########
@@ -292,4 +287,49 @@ public long heapSize() {
}
return ClassSize.align(FIXED_OVERHEAD);
}
+
+ @Override
+ public int getFamilyLengthPosition(int rowLen) {
+ return this.offset + Bytes.SIZEOF_SHORT + rowLen;
+ }
+
+ @Override
+ public int getFamilyInternalPosition(int familyLengthPosition) {
+ return familyLengthPosition + Bytes.SIZEOF_BYTE;
+ }
+
+ @Override
+ public int getQualifierInternalPosition(int famOffset, byte famLength) {
+ return famOffset + famLength;
+ }
+
+ private int getTimestampOffset(final int keylength) {
+ return this.offset + keylength - KeyValue.TIMESTAMP_TYPE_SIZE;
+ }
+
+ @Override
+ public long getTimestamp(int keyLength) {
+ int tsOffset = getTimestampOffset(keyLength);
+ return ByteBufferUtils.toLong(this.buf, tsOffset);
+ }
+
+ @Override
+ public byte getTypeByte(int keyLength) {
+ return ByteBufferUtils.toByte(this.buf, this.offset + keyLength - 1);
+ }
+
+ @Override
+ public int getKeyLength() {
+ return this.length;
+ }
+
+ @Override
+ public boolean equals(Object other) {
+ return super.equals(other);
+ }
+
+ @Override
+ public int hashCode() {
Review comment:
That is a spot bug inference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
