saintstack commented on a change in pull request #2742:
URL: https://github.com/apache/hbase/pull/2742#discussion_r542631191
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##########
@@ -1015,17 +1016,17 @@ private void moveServerRegionsFromGroup(Set<Address>
movedServers, Set<Address>
assignmentFutures.add(Pair.newPair(region, future));
} catch (IOException ioe) {
failedRegions.add(region.getRegionNameAsString());
- LOG.debug("Move region {} from group failed, will retry, current
retry time is {}",
- region.getShortNameToLog(), retry, ioe);
+ LOG.debug("Move region {} from server {} failed, will retry,
current retry time is {}",
Review comment:
nit: 'server' in the log message is redundant; we are always moving
between servers?
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##########
@@ -1015,17 +1016,17 @@ private void moveServerRegionsFromGroup(Set<Address>
movedServers, Set<Address>
assignmentFutures.add(Pair.newPair(region, future));
} catch (IOException ioe) {
failedRegions.add(region.getRegionNameAsString());
- LOG.debug("Move region {} from group failed, will retry, current
retry time is {}",
- region.getShortNameToLog(), retry, ioe);
+ LOG.debug("Move region {} from server {} failed, will retry,
current retry time is {}",
+ region.getShortNameToLog(), owner.getHostname(), retry, ioe);
toThrow = ioe;
}
}
}
}
- waitForRegionMovement(assignmentFutures, failedRegions,
targetGrp.getName(), retry);
+ waitForRegionMovement(assignmentFutures, failedRegions, sourceGroupName,
retry);
if (failedRegions.isEmpty()) {
- LOG.info("All regions from server(s) {} moved to target group {}.",
movedServerNames,
- targetGrp.getName());
+ LOG.info("All regions from server(s) {} moved to source group {}.",
movedServerNames,
Review comment:
Why not say, 'All regions from {} moved from {} to {}, movedServerNames,
sourceGroupName, targetGroupName?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
