[GitHub] [hbase] caroliney14 commented on a change in pull request #2762: HBASE-25329 Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

[GitBox]

caroliney14 commented on a change in pull request #2762:
URL: https://github.com/apache/hbase/pull/2762#discussion_r543842413



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
##########
@@ -3549,11 +3554,24 @@ public void updateRegionsInTransitionMetrics() {
       if (oldestRITTime < ritTime) {
         oldestRITTime = ritTime;
       }
+      if (counter < 500) { // Record 500 oldest RITs
+        oldestRITHashesAndStates.add(

Review comment:
       I think it makes sense to only record RITs over threshold, since those 
would be the problematic ones




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org