virajjasani commented on pull request #2778:
URL: https://github.com/apache/hbase/pull/2778#issuecomment-746356621
I think this approach of removing key if `{"key"=""}` is provided as updated
peer base config sounds good one.
> @virajjasani Do you think if it is standard to have conf upgrade before
the HBase rolling upgrade? If not, we might need to rework on updating the peer
configs
For rolling upgrade, updating configs in new bits is common before
performing rolling restart of master and RS (which can also update config
symlinks e.g /etc/conf/hbase), hence this patch should fit well for upgrades
IMHO.
+1 for the PR overall once @bharathv and @gjacoby126 's remaining comments
are addressed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
