saintstack commented on a change in pull request #2776:
URL: https://github.com/apache/hbase/pull/2776#discussion_r546259202
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java
##########
@@ -1598,16 +1621,21 @@ public static boolean matchingRows(final Cell left,
final Cell right) {
* @return True if same row and column.
*/
public static boolean matchingRowColumn(final Cell left, final Cell right) {
- if ((left.getRowLength() + left.getFamilyLength()
- + left.getQualifierLength()) != (right.getRowLength() +
right.getFamilyLength()
- + right.getQualifierLength())) {
+ short lrowlength = left.getRowLength();
+ short rrowlength = right.getRowLength();
+ byte lfamlength = left.getFamilyLength();
+ byte rfamlength = right.getFamilyLength();
+ int lqlength = left.getQualifierLength();
+ int rqlength = right.getQualifierLength();
+ // match length
+ if ((lrowlength + lfamlength + lqlength) != (rrowlength + rfamlength +
rqlength)) {
Review comment:
I like the @anoopsjohn suggestion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
