saintstack commented on pull request #2729:
URL: https://github.com/apache/hbase/pull/2729#issuecomment-748547958


   Patch is also incomplete.... needs some more work done
   ```
   
   $ grep -ri segregate hbase-*/src
   
hbase-server/src/main/java/org/apache/hadoop/hbase/favored/FavoredNodeLoadBalancer.java:
      // Segregate the regions into two types:
   
hbase-server/src/main/java/org/apache/hadoop/hbase/favored/FavoredNodeLoadBalancer.java:
      Pair<Map<ServerName,List<RegionInfo>>, List<RegionInfo>> 
segregatedRegions =
   
hbase-server/src/main/java/org/apache/hadoop/hbase/favored/FavoredNodeLoadBalancer.java:
          segregateRegionsAndAssignRegionsWithFavoredNodes(regions, servers);
   
hbase-server/src/main/java/org/apache/hadoop/hbase/favored/FavoredNodeLoadBalancer.java:
      Map<ServerName,List<RegionInfo>> regionsWithFavoredNodesMap = 
segregatedRegions.getFirst();
   
hbase-server/src/main/java/org/apache/hadoop/hbase/favored/FavoredNodeLoadBalancer.java:
      List<RegionInfo> regionsWithNoFavoredNodes = 
segregatedRegions.getSecond();
   
hbase-server/src/main/java/org/apache/hadoop/hbase/favored/FavoredNodeLoadBalancer.java:
  segregateRegionsAndAssignRegionsWithFavoredNodes(List<RegionInfo> regions,
   
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredStochasticBalancer.java:
   * Round robin assignment: Segregate the regions into two types:
   
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredStochasticBalancer.java:
      // Segregate favored and non-favored nodes regions and assign accordingly.
   
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredStochasticBalancer.java:
      Pair<Map<ServerName,List<RegionInfo>>, List<RegionInfo>> 
segregatedRegions =
   
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredStochasticBalancer.java:
        segregateRegionsAndAssignRegionsWithFavoredNodes(regionSet, servers);
   
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredStochasticBalancer.java:
      Map<ServerName, List<RegionInfo>> regionsWithFavoredNodesMap = 
segregatedRegions.getFirst();
   
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredStochasticBalancer.java:
        generateFNForRegionsWithoutFN(helper, segregatedRegions.getSecond());
   
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/FavoredStochasticBalancer.java:
  segregateRegionsAndAssignRegionsWithFavoredNodes(Collection<RegionInfo> 
regions,
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to