Apache9 commented on a change in pull request #2792:
URL: https://github.com/apache/hbase/pull/2792#discussion_r546314334
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcDuplexHandler.java
##########
@@ -103,8 +103,8 @@ private void writeRequest(ChannelHandlerContext ctx, Call
call, ChannelPromise p
ctx.write(buf, withoutCellBlockPromise);
ChannelPromise cellBlockPromise = ctx.newPromise();
ctx.write(cellBlock, cellBlockPromise);
- PromiseCombiner combiner = new PromiseCombiner();
- combiner.addAll(withoutCellBlockPromise, cellBlockPromise);
+ PromiseCombiner combiner = new PromiseCombiner(ctx.executor());
+ combiner.addAll((ChannelFuture) withoutCellBlockPromise,
cellBlockPromise);
Review comment:
The method which takes Promises as parameters is deprecated.
https://github.com/netty/netty/blob/3e8e52725bbd9d999873880956bc8f241372daa8/common/src/main/java/io/netty/util/concurrent/PromiseCombiner.java#L123
So here we cast the first one to a future to let it call the method which
takes Futures as parameters(Promise is a sub interface of Future).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
