[
https://issues.apache.org/jira/browse/HBASE-5342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273447#comment-13273447
]
Zhihong Yu commented on HBASE-5342:
-----------------------------------
Nice work.
Why is TreeSet needed below ?
{code}
- Set<String> tableSet = new HashSet<String>();
+ Set<byte[]> tableSet = new TreeSet<byte[]>(Bytes.BYTES_COMPARATOR);
{code}
{code}
+ // Users with CREATE/ADMIN Rights needs to modify .META. and _acl_ table
{code}
'needs to' -> 'need to'
{code}
+ // e.g. new table writes in .META. remove table writes in .META. and _acl_.
{code}
Please rewrite the above so that it is clearer.
{code}
+ return AuthResult.allow("Table permission granted", user, permRequest,
tableName);
{code}
Minor: there is a white space at the end of above line - I found it on review
board.
{code}
+ * Returns true if this permission describes a user global permission.
{code}
'user global' -> 'global user'
For whoami.rb, it contains the same contents 4 times. Please remove 3 of them.
> Grant/Revoke global permissions
> -------------------------------
>
> Key: HBASE-5342
> URL: https://issues.apache.org/jira/browse/HBASE-5342
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Matteo Bertozzi
> Attachments: HBASE-5342-draft.patch, HBASE-5342-v0.patch,
> HBASE-5342-v1.patch, HBASE-5342-v2.patch, HBASE-5342-v3.patch
>
>
> HBASE-3025 introduced simple ACLs based on coprocessors. It defines
> global/table/cf/cq level permissions. However, there is no way to
> grant/revoke global level permissions, other than the hbase.superuser conf
> setting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
