lujiefsi commented on pull request #2809: URL: https://github.com/apache/hbase/pull/2809#issuecomment-750732297
> (hahaha, sorry. I'm overlapping with Duo :) ) > > > I try to use code "hbck = TEST_UTIL.getConnection(USER_NONE).getHbck()" to gain the hbck, but UT still failed to pass. So I perfer to commit this PR without UT as its patch works fine in a real cluster. > > Look at `getAsyncConnection` in `HBaseTestingUtility.java`. Can you verify what `User` is here? > > You could also just instantiate your own `Connection` and call `getHbck()` on that `Connection`, to avoid whatever HBaseTestingUtility is doing. The `TestAccessController#testRead()` method has an example of creating a new `Connection`. > > Could you try that, please? The user is the user who run t > I think the fix is OK for now. Checked HBASE-19400, we want to move the permission check out of a CP but it is only half done... As you mention HBASE-19400, I check the patches and find that you add "requirePermission" in RS, but the API like stopServer do not call it for security check. I think there are must some other APIs on RSRpcServices need security check! I have created a issuse to track it. https://issues.apache.org/jira/browse/HBASE-25441 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
