saintstack commented on a change in pull request #2812:
URL: https://github.com/apache/hbase/pull/2812#discussion_r549476078
##########
File path:
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestTableDescriptorBuilder.java
##########
@@ -292,6 +347,13 @@ public void testStringCustomizedValues() {
"'testStringCustomizedValues', " +
"{TABLE_ATTRIBUTES => {DURABILITY => 'ASYNC_WAL'}}, {NAME => 'cf',
BLOCKSIZE => '1000'}",
htd.toStringCustomizedValues());
+
+ htd =
TableDescriptorBuilder.newBuilder(htd).setMaxFileSize("10737942528").build();
+ assertEquals(
+ "'testStringCustomizedValues', " +
+ "{TABLE_ATTRIBUTES => {DURABILITY => 'ASYNC_WAL', "
+ + "MAX_FILESIZE => '10737942528 B (10 GB 512 KB)'}}, {NAME => 'cf',
BLOCKSIZE => '1000'}",
Review comment:
Does it have to have a space between the number and the unit? Can it be
10GB instead of '10 GB'?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
