anoopsjohn commented on a change in pull request #2821:
URL: https://github.com/apache/hbase/pull/2821#discussion_r549550856



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/io/util/MemorySizeUtil.java
##########
@@ -234,7 +234,7 @@ public static long getOnHeapCacheSize(final Configuration 
conf) {
   }
 
   /**
-   * @param conf used to read config for bucket cache size. (< 1 is treated as 
% and > is treated as MiB)
+   * @param conf used to read config for bucket cache size. 

Review comment:
       Yes Stack.  The bucket cache size can only be specified as absolute MBs 
value.  we no longer support on heap Bucket cache and so size as % of heap.  
And min value for this is 1. (1 MB)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to