infraio commented on a change in pull request #2825:
URL: https://github.com/apache/hbase/pull/2825#discussion_r549906989
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -832,7 +832,7 @@ private void finishActiveMasterInitialization(MonitoredTask
status) throws IOExc
HBaseFsck.createLockRetryCounterFactory(this.conf).create());
} finally {
if (result != null) {
- IOUtils.closeQuietly(result.getSecond());
+ Closeables.close(result.getSecond(), true);
Review comment:
Seems there are three methods you used: Closeables.closeQuietly,
Closeables.close, IOUtils.closeQuietly. Do we have a developer guide doc about
what we recommend to use?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
