Apache9 commented on pull request #2714: URL: https://github.com/apache/hbase/pull/2714#issuecomment-753617483
Any other concerns here @apurtell ? When implementing HBASE-25458, I found that it is a pain that we do not have VisibleForTesting annotation. For example, this method in HRegion `OperationStatus[] batchMutate(BatchOperation<?> batchOp) throws IOException` is declared as package private, the javadoc is very long and after reading it, there is no information about why it is marked as package private, after reference searching, it is referenced in a test. So if we have a VisibleForTesting annotation on this method, I could know that this method is exposed for testing. So I do not think we should reject VisibleForTesting annotation in all classes. With the check proposed in this PR, we have the ability to only avoid the annotation in public and limited private classes, so I think our concerns on messing up the API could be resolved. What do you think? Thanks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
