[GitHub] [hbase] mokai87 commented on a change in pull request #2846: HBASE-24755 [LOG][RSGroup]Error message is confusing while adding a offline RS to rsgroup

[GitBox]

mokai87 commented on a change in pull request #2846:
URL: https://github.com/apache/hbase/pull/2846#discussion_r552417793



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##########
@@ -1233,9 +1233,8 @@ public void moveServers(Set<Address> servers, String 
targetGroupName) throws IOE
       Address firstServer = servers.iterator().next();
       RSGroupInfo srcGrp = getRSGroupOfServer(firstServer);
       if (srcGrp == null) {
-        // Be careful. This exception message is tested for in 
TestRSGroupsBase...
-        throw new ConstraintException("Source RSGroup for server " + 
firstServer
-            + " does not exist.");
+        // Be careful. This exception message is tested for in 
TestRSGroupAdmin2...
+        throw new ConstraintException("Server " + firstServer + " does not 
exist or offline.");

Review comment:
       updated




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org