Peter Somogyi created HBASE-25467:
-------------------------------------
Summary: Fix error prone problems on branch-2.2
Key: HBASE-25467
URL: https://issues.apache.org/jira/browse/HBASE-25467
Project: HBase
Issue Type: Bug
Components: build
Affects Versions: 2.2.7
Reporter: Peter Somogyi
Assignee: Peter Somogyi
Nightly builds on branch-2.2 do not succeed for more than a month. General
checks show a few error prone warnings. These were already corrected on
branch-2.3+ (HBASE-23753). A recent error prone upgrade to 2.4.0 on branch-2.2
requires these code fixes.
{noformat}
[ERROR]
/home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_branch-2.2/component/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java:[1347,18]
error: [ProtoFieldNullComparison] Protobuf fields cannot be null.
(see https://errorprone.info/bugpattern/ProtoFieldNullComparison)
Did you mean 'if ((!proto.getCellList().isEmpty() && !values.isEmpty()) ||'?
[ERROR]
/home/jenkins/jenkins-home/workspace/HBase_HBase_Nightly_branch-2.2/component/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegionInfoBuilder.java:[122,9]
error: [ComparableType] Type of Comparable (RegionInfo) is not the same as
implementing class (MutableRegionInfo).
(see https://errorprone.info/bugpattern/ComparableType)
[INFO] 2 errors
{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)